Skip to content
This repository was archived by the owner on Mar 16, 2020. It is now read-only.

add support for flutter run/build modes#1024

Merged
devoncarew merged 2 commits into
masterfrom
add_run_modes
Jun 7, 2016
Merged

add support for flutter run/build modes#1024
devoncarew merged 2 commits into
masterfrom
add_run_modes

Conversation

@devoncarew

@devoncarew devoncarew commented Jun 7, 2016

Copy link
Copy Markdown
Contributor

Add support for running flutter apps in the three build modes (debug, profile, release) (fix flutter/flutter#4042).

screen shot 2016-06-06 at 4 27 41 pm

@danrubel

@danrubel

danrubel commented Jun 7, 2016

Copy link
Copy Markdown

LGTM

@devoncarew devoncarew merged commit 0da0ac1 into master Jun 7, 2016
@sethladd sethladd deleted the add_run_modes branch June 8, 2016 17:40
@sethladd

sethladd commented Jun 8, 2016

Copy link
Copy Markdown
Contributor

Nice! how do I control this in my YAML launch config?

@devoncarew

Copy link
Copy Markdown
Contributor Author

It's controlled through the toolbar GUI. Thinking about it, the state seemed more transient - per user, and not something you'd necessarily check in to scm.

@devoncarew

Copy link
Copy Markdown
Contributor Author

It's available in the latest release to try out -

@sethladd

sethladd commented Jun 8, 2016

Copy link
Copy Markdown
Contributor

not something you'd necessarily check in to scm.

True. Should we remove debug: true from main.yaml then? Also, I thought we were ignoring .atom directory anyway? I always assumed that file shouldn't be checked in.

@devoncarew

Copy link
Copy Markdown
Contributor Author

Yup, re: removing debug: true.

We do exclude the .atom dir for the flutter project we create, but in general I think launch configs should be sharable between users. They should describe the application to launch - the type of app, the path to the main file, ... . Other launch settings, like debug/release, are more ephemeral.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to configure release mode with Atom plugin?

3 participants