switch off locale "C" override for opencl compilation by default#18342
Merged
TurboGit merged 1 commit intodarktable-org:masterfrom Feb 2, 2025
Merged
switch off locale "C" override for opencl compilation by default#18342TurboGit merged 1 commit intodarktable-org:masterfrom
TurboGit merged 1 commit intodarktable-org:masterfrom
Conversation
TurboGit
approved these changes
Feb 2, 2025
Member
TurboGit
left a comment
There was a problem hiding this comment.
All good to me, we can also later only do that if AMD is in the list of OpenCL driver.
Contributor
|
Tested this PR and cannot reproduce #18196 anymore. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #18196
This does two things:
I have not tested this beyond that it compiles and runs, because I cannot easily replicate the original issue to verify this fixes it.
RELEASE NOTE:
If you have problems with OpenCL that you believe may be caused by this change, please do two things:
opencl_force_c_locale=anythingto your~/.config/darktable/darktablercfile.