Skip to content

[GUI] Fix Cyrillic rendering in some themes by removing Segoe UI Light#16981

Merged
TurboGit merged 1 commit intodarktable-org:masterfrom
victoryforce:fix-13084
Jun 12, 2024
Merged

[GUI] Fix Cyrillic rendering in some themes by removing Segoe UI Light#16981
TurboGit merged 1 commit intodarktable-org:masterfrom
victoryforce:fix-13084

Conversation

@victoryforce
Copy link
Copy Markdown
Collaborator

Resolves #13084.

There are themes that do not use Segoe UI Light, so using this font in the theme is definitely not necessary for correct rendering. But I want to ask everyone to test this change as much as possible now, because merging it into 4.8 would allow to abandon the need for an outdated package base for building darktable on Windows.

@wpferguson
Copy link
Copy Markdown
Member

I'll still use the current package base to build for windows this cycle. However, if this works, then I'll update for next cycle.

@victoryforce
Copy link
Copy Markdown
Collaborator Author

The idea is that IF this fix is ​​accepted for 4.8, there will be no need to create darktable for Windows in an outdated environment. Which is generally a good and proper way to support the Windows platform. Let's not forget that the nightly builds now have a problem with the Cyrillic interface.

That's why I ask everyone who can run darktable on Windows to check it.

@wpferguson
Copy link
Copy Markdown
Member

Changing the build environment a week before release without a chance to do any real world testing is a recipe for disaster.

Copy link
Copy Markdown
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit added this to the 4.8 milestone Jun 12, 2024
@TurboGit TurboGit added bugfix pull request fixing a bug understood: incomplete devs lack some important info to start fixing scope: UI user interface and interactions depends: external lib bug: upstream he bug needs a fix outside of the scope of darktable, in an external lib or in a driver labels Jun 12, 2024
@TurboGit TurboGit merged commit b45cdde into darktable-org:master Jun 12, 2024
@kmilos
Copy link
Copy Markdown
Contributor

kmilos commented Jun 12, 2024

As mentioned, I'd rather we fix the cause when misusing any and all font designations rather than just address one symptom. @Nilvus

@victoryforce victoryforce deleted the fix-13084 branch June 13, 2024 05:02
@Nilvus
Copy link
Copy Markdown
Contributor

Nilvus commented Jun 13, 2024

@kmilos: I no more practice photos and so stop to follow darktable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: upstream he bug needs a fix outside of the scope of darktable, in an external lib or in a driver bugfix pull request fixing a bug depends: external lib scope: UI user interface and interactions understood: incomplete devs lack some important info to start fixing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GUI] The default theme (and a few others) have problems with Cyrillic text on Windows

5 participants