Fix workflow resource path lookup #1564
Conversation
In standalone mode, if the resource path is not explicitly defined in the daprd process arguments, the workflow engine fails to locate the resource files, used to fetch the actor state store component manifest. This change updates the resource path lookup logic to use the default component path when the resource path is not defined. Signed-off-by: joshvanl <me@joshvanl.dev>
6165396 to
f26a4c0
Compare
acroca
left a comment
There was a problem hiding this comment.
Shouldn't we add tests for this?
| import "github.com/spf13/cobra" | ||
|
|
||
| var ( | ||
| daprRuntimePath string |
There was a problem hiding this comment.
If I understand correctly, you moved this to its own package so it's reusable from both pkg/workflow and cmd packages without introducing a circular dependency, right?
Why not keep it as it was (in the dapr.go) and pass it as an argument when calling functions in the pkg/workflow like it's done for the other options like the kubernetes mode?
There was a problem hiding this comment.
pkg/workflow is called from the cmd/workflow sub command sub package commands. cmd imports cmd/workflow to register the workflow sub commands.
We either need to have the flag registered and available from a third shared package, or register it multiple times for everywhere it is needed.
In standalone mode, if the resource path is not explicitly defined in the daprd process arguments, the workflow engine fails to locate the resource files, used to fetch the actor state store component manifest. This change updates the resource path lookup logic to use the default component path when the resource path is not defined.