Skip to content

feat: Allow configuring the scheduler host on init #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yaron2 merged 3 commits into from
Jul 15, 2025
Merged

feat: Allow configuring the scheduler host on init #1520

yaron2 merged 3 commits into from
Jul 15, 2025

Conversation

@acroca
Copy link
Member

@acroca acroca commented Jul 9, 2025 •
edited
Loading

Description

Added a new flag for dapr init where the user can specify the scheduler host.

This allows running dapr apps pointing to a remote scheduler, as long as the configured scheduler host address is reachable from the dapr app.

To test this feature, I have a container with dind and dapr, where I executed:

dapr init --scheduler-override-broadcast-host-port dind-service

Then from another container with access to the docker instance from dind, I'm running a service with:

 dapr run --app-id=test \
                --metrics-port=9091 \
                --scheduler-host-address=dind-service:50006 \
                --placement-host-address=dind-service:50005 \
                --dapr-grpc-port 50001 \
                --app-port 50070 \
                --app-protocol grpc \
                --log-level debug \
                go run .

With this change, I see the following logs:

INFO[0000] Connected and received scheduler hosts addresses: [dind-service:50006]  app_id=test instance=7eb14174350b scope=dapr.runtime.scheduler.watchhosts type=log ver=1.15.6
DEBU[0000] Attempting to connect to Scheduler at address: dind-service:50006  app_id=test instance=7eb14174350b scope=dapr.runtime.scheduler.clients type=log ver=1.15.6
INFO[0000] Scheduler client initialized for address: dind-service:50006  app_id=test instance=7eb14174350b scope=dapr.runtime.scheduler.clients type=log ver=1.15.6
...
INFO[0002] Scheduler stream connected for [JOB_TARGET_TYPE_ACTOR_REMINDER]  app_id=test instance=7eb14174350b scope=dapr.runtime.scheduler.cluster type=log ver=1.15.6

Without this change, it failed:

INFO[0000] Connected and received scheduler hosts addresses: [localhost:50006]  app_id=test instance=7eb14174350b scope=dapr.runtime.scheduler.watchhosts type=log ver=1.15.6
DEBU[0000] Attempting to connect to Scheduler at address: localhost:50006  app_id=test instance=7eb14174350b scope=dapr.runtime.scheduler.clients type=log ver=1.15.6
INFO[0000] Scheduler client initialized for address: localhost:50006  app_id=test instance=7eb14174350b scope=dapr.runtime.scheduler.clients type=log ver=1.15.6
...
ERRO[0002] Failed to watch scheduler jobs, retrying: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp [::1]:50006: connect: connection refused"  app_id=test instance=7eb14174350b scope=dapr.runtime.scheduler.cluster type=log ver=1.15.6

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1518

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@acroca
feat: Allow configuring the scheduler advertised address on init
883180f 
Signed-off-by: Albert Callarisa <albert@diagrid.io>
@acroca acroca requested review from a team as code owners July 9, 2025 12:24
@acroca acroca changed the title feat: Allow configuring the scheduler advertised address on init feat: Allow configuring the scheduler host on init Jul 9, 2025
JoshVanL
JoshVanL previously approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@JoshVanL JoshVanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also backport this to release-1.15 and create a patch release.

@acroca
Rename field to make it clearer
847ed81 
Signed-off-by: Albert Callarisa <albert@diagrid.io>
@acroca acroca force-pushed the set-scheduler-binding-address-on-init branch from 5263b25 to 847ed81 Compare July 10, 2025 05:45
@acroca acroca requested a review from JoshVanL July 10, 2025 05:47
@acroca
Replace SprintF with concatenation as per linter recommendation.
d4731e5 
Signed-off-by: Albert Callarisa <albert@diagrid.io>
@acroca acroca force-pushed the set-scheduler-binding-address-on-init branch 3 times, most recently from 72d8a7c to d4731e5 Compare July 10, 2025 07:18
@acroca acroca mentioned this pull request Jul 10, 2025
Merged
@acroca
Copy link
Member Author

acroca commented Jul 10, 2025

Patch PR here: #1521

@JoshVanL
Copy link
Contributor

JoshVanL commented Jul 11, 2025

@acroca tests are failing

@msfussell
Copy link
Member

msfussell commented Jul 11, 2025

@acroca - Please raise a PR for Dapr docs.

@acroca acroca mentioned this pull request Jul 14, 2025
Merged
7 tasks
@acroca
Copy link
Member Author

acroca commented Jul 14, 2025

@acroca - Please raise a PR for Dapr docs.

@msfussell Thanks for reminding updating the docs :) dapr/docs#4721

@yaron2 yaron2 merged commit edb70cf into dapr:master Jul 15, 2025
57 of 64 checks passed
@acroca acroca deleted the set-scheduler-binding-address-on-init branch July 15, 2025 12:15
@nelson-parente nelson-parente added this to the v1.16 milestone Aug 19, 2025
@marcduiker
Copy link
Contributor

marcduiker commented Nov 18, 2025

@holopin-bot @acroca Here's a digital badge as a small token of appreciation.

@holopin-bot
Copy link

holopin-bot bot commented Nov 18, 2025

Congratulations @acroca, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmi4ezotd000cjw04sbkp3nu8

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaron2 yaron2 yaron2 approved these changes

@cicoyle cicoyle cicoyle approved these changes

@JoshVanL JoshVanL Awaiting requested review from JoshVanL

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.16

Development

Successfully merging this pull request may close these issues.

DAPR 1.15 not working in standalone mode when called from a VM

7 participants

@acroca @JoshVanL @msfussell @marcduiker @yaron2 @cicoyle @nelson-parente