Skip to content

max-body-size and read-buffer-size do not accept units #1489

@mikeee

Description

@mikeee

Expected Behavior

I should be able to define the arguments max-body-size and read-buffer-size with units, e.g. "4Mi" as per docs.
https://v1-15.docs.dapr.io/reference/arguments-annotations-overview/

Actual Behavior

At the moment, the flag is being parsed as an int rather than a string before invoking the runtime.

Steps to Reproduce the Problem

dapr run --app-id custom-grpc-client \
		 -d ./config \
		 --max-body-size 4Mi \
		 --log-level debug \
		 go run ./custom-grpc-client/main.go

Release Note

RELEASE NOTE: FIX Allow max-body-size and read-buffer-size to be defined with units

Metadata

Metadata

Assignees

Labels

P0kind/bugSomething isn't working

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions