Update unit tests

dapplion · dapplion · commit 75351799ede0 · 2021-01-21T17:01:07.000+01:00
diff --git a/build/src/src/calls/removeDevice.ts b/build/src/src/calls/removeDevice.ts
@@ -1,6 +1,8 @@
 import { getUserList, removeClient } from "../openvpn";
 import { MAIN_ADMIN_NAME } from "../params";
 
+export const REMOVE_MAIN_ADMIN_ERROR = "Cannot remove the main admin user";
+
 /**
  * Removes the device with the provided id, if exists.
  * @param id "new-device"
@@ -9,7 +11,7 @@ export async function removeDevice({ id }: { id: string }): Promise<void> {
   const deviceArray = await getUserList();
 
   if (id === MAIN_ADMIN_NAME) {
-    throw Error("Cannot remove the main admin user");
+    throw Error(REMOVE_MAIN_ADMIN_ERROR);
   }
 
   if (!deviceArray.includes(id)) {
diff --git a/build/src/test/calls/listDevices.test.ts b/build/src/test/calls/listDevices.test.ts
@@ -12,10 +12,10 @@ describe("Call function: listDevices", () => {
     { cn: "tom", ip: "172.33.0.2" }
   ];
   const userResult = [
-    { id: "dappnode_admin", admin: true, ip: "172.33.0.1" },
-    { id: "mobile", admin: false, ip: "" },
-    { id: "guest", admin: false, ip: "" },
-    { id: "tom", admin: true, ip: "172.33.0.2" }
+    { id: "dappnode_admin" },
+    { id: "mobile" },
+    { id: "guest" },
+    { id: "tom" }
   ];
   // sinon.replace(,));   <--- to replace an inside function
   const getUserList = sinon.stub();
diff --git a/build/src/test/calls/removeDevice.test.ts b/build/src/test/calls/removeDevice.test.ts
@@ -2,6 +2,7 @@ import "mocha";
 import { expect } from "chai";
 import sinon from "sinon";
 import proxyquire from "proxyquire";
+import { REMOVE_MAIN_ADMIN_ERROR } from "../../src/calls/removeDevice";
 
 describe("Call function: removeDevice", () => {
   // This function calls getUserList and getCCD to build
@@ -46,6 +47,6 @@ describe("Call function: removeDevice", () => {
     } catch (e) {
       error = e.message;
     }
-    expect(error).to.equal("You cannot remove an admin user");
+    expect(error).to.equal(REMOVE_MAIN_ADMIN_ERROR);
   });
 });
