Fix isSignerSelected bug and swapped JSDoc comments in useStakerModals#2399
Closed
Fix isSignerSelected bug and swapped JSDoc comments in useStakerModals#2399
Conversation
* Premium backup stakers Modal * premium modal fix * backup active and available checks * update comments
* [WIP] new disclaimer modal * formatting files * disclaimer data fix * modal copy fix * Accordion component * rename Accordion * dark mode fixes
Co-authored-by: Marketen <36164126+Marketen@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Refactor stakers modals for improved UI components
Fix isSignerSelected bug and swapped JSDoc comments in useStakerModals
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes
isSignerSelectedlogic bug inStakerNetwork.tsx:Boolean(newWeb3signer?.isSelected)reads theisSelectedproperty from the original API data (whether the signer was previously active), not whether the user selected one in the UI. When a user newly selects a web3signer that wasn't previously active,isSelectedisfalseon the API object, so premium modals never trigger.useStakerModals.tsx:handleNonPremiumModalClosewas documented as "premium" andhandlePremiumModalCloseas "non-premium".💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.