Skip to content

Enforce json-file logging as a mandatory default, block package-level logging overrides#2389

Closed
Copilot wants to merge 4 commits intodevelopfrom
copilot/sub-pr-2384
Closed

Enforce json-file logging as a mandatory default, block package-level logging overrides#2389
Copilot wants to merge 4 commits intodevelopfrom
copilot/sub-pr-2384

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 23, 2026

Packages could specify their own logging driver (e.g. journald) in their docker-compose.yml and have it pass through to the final compose, since logging was a passthrough safe key with only a soft default.

Changes

  • setDappnodeComposeDefaults.ts: Moves logging from the overridable defaults section to the mandatory overrides section, and removes logging from dockerComposeSafeKeys passthrough — ensuring json-file with max-size: 10m / max-file: 3 is always enforced regardless of what a package declares.
// Before: logging was overridable — packages could replace it
logging: { driver: "json-file", options: { "max-size": "10m", "max-file": "3" } },  // overridable default
...pick(serviceUnsafe, dockerComposeSafeKeys.filter((k) => k !== "build"))          // logging passed through here

// After: logging is mandatory — package value is discarded
...pick(serviceUnsafe, dockerComposeSafeKeys.filter((k) => k !== "build" && k !== "logging"))
logging: { driver: "json-file", options: { "max-size": "10m", "max-file": "3" } },  // mandatory override
  • Test fixtures (dappmanager, vpn): Updated parsed compose snapshots to reflect json-file replacing journald.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Remove journald logging configuration from Docker Compose files Enforce json-file logging as a mandatory default, block package-level logging overrides Feb 23, 2026
Copilot AI requested a review from Marketen February 23, 2026 15:29
Base automatically changed from pablo/remove-logging-journal to develop February 27, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants