gets avatars URL from mirror too#2385
Merged
Marketen merged 1 commit intofeat/mirror-content-providerfrom Feb 23, 2026
Merged
Conversation
pablomendezroyo
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request standardizes how avatar URLs are constructed and handled throughout the codebase. The main change is to always use the
fileToGatewayUrlfunction for avatar files, removing fallback logic to manifest URLs. Additionally, support for a new"mirror"file source is introduced, enabling avatar files to be fetched from HTTP mirrors with proper URL construction. Type definitions are updated to reflect this new source and its required fields.Avatar URL handling improvements:
All avatar URL assignments now exclusively use
fileToGatewayUrl, removing fallback to manifest URLs in functions such asfetchDirectory,fetchDnpRequest,fetchRegistryIpfsData,getOptimismConfig, andgetAllin various files. [1] [2] [3] [4] [5] [6] [7] [8]The repository logic is updated so that avatar file entries are always constructed, and mirror sources are handled explicitly, removing previous logic that set
manifest.avatarUrldirectly when using mirrors.Distributed file source enhancements:
The
DistributedFileSourcetype now includes"mirror", and theDistributedFileinterface is updated to requirefilenameandpackageHashfor mirror sources, with clarifying comments. [1] [2]The
fileToGatewayUrlutility function is enhanced to generate proper URLs for mirror sources, using the base mirror URL, package hash, and filename, and returning an empty string if required fields are missing.