Skip to content

Standardize Starknet docs URLs#2361

Merged
Marketen merged 3 commits intomateu/update-starknet-copiesfrom
copilot/sub-pr-2360
Feb 4, 2026
Merged

Standardize Starknet docs URLs#2361
Marketen merged 3 commits intomateu/update-starknet-copiesfrom
copilot/sub-pr-2360

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 4, 2026

The Starknet staking UI had inconsistent documentation URL handling with hard-coded URLs instead of using centralized constants.

Changes:

  • URL standardization - Replaced hard-coded docs URL with centralized docsUrl.starknetDocs constant and added externalUrlProps for consistent external link handling

Files modified:

  • packages/admin-ui/src/pages/rollups/components/Starknet.tsx - Import and use centralized docs constant

Before:

<a href="https://docs.dappnode.io/docs/user/staking/starknet/solo/" target="_blank">
  docs
</a>

After:

<a href={docsUrl.starknetDocs} {...externalUrlProps}>
  docs
</a>

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Marketen <36164126+Marketen@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 4, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • binaries.soliditylang.org
    • Triggering command: /usr/local/bin/node /usr/local/bin/node ./build/cli.bundled.js obtain --solc=0.5.16 /home/REDACTED/.cache/node-gyp/20.20.0/deps/zlib -I /home/REDACTED/.cache/node-gyp/20.20.0/deps/v8/include -I ../deps/cpu_features/include -I ../deps/cpu_features/include/internal --64 s/sr�� right --viewport-size &#39;1280, 720&#39; --output-dir /tmp/playwright-luser.email (dns block)
  • ethereum.github.io
    • Triggering command: /usr/local/bin/node /usr/local/bin/node ./build/cli.bundled.js obtain --solc=0.5.16 /home/REDACTED/.cache/node-gyp/20.20.0/deps/zlib -I /home/REDACTED/.cache/node-gyp/20.20.0/deps/v8/include -I ../deps/cpu_features/include -I ../deps/cpu_features/include/internal --64 s/sr�� right --viewport-size &#39;1280, 720&#39; --output-dir /tmp/playwright-luser.email (dns block)
  • relay.trufflesuite.com
    • Triggering command: /usr/local/bin/node /usr/local/bin/node ./build/cli.bundled.js obtain --solc=0.5.16 /home/REDACTED/.cache/node-gyp/20.20.0/deps/zlib -I /home/REDACTED/.cache/node-gyp/20.20.0/deps/v8/include -I ../deps/cpu_features/include -I ../deps/cpu_features/include/internal --64 s/sr�� right --viewport-size &#39;1280, 720&#39; --output-dir /tmp/playwright-luser.email (dns block)
  • solc-bin.ethereum.org
    • Triggering command: /usr/local/bin/node /usr/local/bin/node ./build/cli.bundled.js obtain --solc=0.5.16 /home/REDACTED/.cache/node-gyp/20.20.0/deps/zlib -I /home/REDACTED/.cache/node-gyp/20.20.0/deps/v8/include -I ../deps/cpu_features/include -I ../deps/cpu_features/include/internal --64 s/sr�� right --viewport-size &#39;1280, 720&#39; --output-dir /tmp/playwright-luser.email (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update stakers' Starknet copies for better user flow Fix Starknet validator terminology and standardize docs URLs Feb 4, 2026
Copilot AI requested a review from Marketen February 4, 2026 15:29
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo changes made in this file

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to StarknetFullNode.tsx have been reverted in commit d7047a6. The file now matches its original state with the "sign attestations" terminology restored.

The only remaining change from the original review is in Starknet.tsx where the hard-coded docs URL was replaced with the centralized docsUrl.starknetDocs constant.

Co-authored-by: Marketen <36164126+Marketen@users.noreply.github.com>
Copilot AI changed the title Fix Starknet validator terminology and standardize docs URLs Standardize Starknet docs URLs Feb 4, 2026
Copilot AI requested a review from Marketen February 4, 2026 15:38
@Marketen Marketen marked this pull request as ready for review February 4, 2026 15:39
@Marketen Marketen requested a review from a team as a code owner February 4, 2026 15:39
@Marketen Marketen merged commit 3d67458 into mateu/update-starknet-copies Feb 4, 2026
@Marketen Marketen deleted the copilot/sub-pr-2360 branch February 4, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants