Merged
Conversation
pablomendezroyo
requested changes
Oct 22, 2025
| const removingContainers = dnpData.containers.filter(c => c.state === "removing"); | ||
| if (removingContainers.length > 0) { | ||
| const serviceNames = removingContainers.map(c => c.serviceName).join(", "); | ||
| logs.warn(`dockerComposeUpPackage: Cannot proceed, services in 'removing' state: ${serviceNames}`); |
Contributor
There was a problem hiding this comment.
I would remove warn log since u are already throwing and this error should be logged afterwards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the
dockerComposeUpPackagefunction indockerComposeUp.tsto enhance reliability and prevent race conditions. The main changes are the addition of an in-process locking mechanism to prevent concurrentdocker-compose upcalls for the same compose file, and a check to block operations if any container is in a 'removing' state.Concurrency control and reliability improvements:
composeUpLocks) to prevent concurrentdockerComposeUpPackageexecutions for the samecomposePath, ensuring only one operation per compose file runs at a time. [1] [2] [3]Container state validation:
dockerComposeUpPackagefrom running if any service container is in the 'removing' state, improving error handling and preventing potential issues with partially removed containers.