Build: Check if libatomic is needed#52
Merged
danvratil merged 1 commit intoqcoro:mainfrom Mar 28, 2022
Merged
Conversation
Contributor
Check libatomic and link QCoro against it if necessary.
r-value
added a commit
to r-value/archriscv-packages
that referenced
this pull request
Mar 28, 2022
+ Adapt patch to latest release + Better approach for atomic operations + Changes upstreamed in qcoro/qcoro#52
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Mar 28, 2022
+ Adapt patch to latest release + Better approach for atomic operations + Changes upstreamed in qcoro/qcoro#52
Collaborator
|
Thanks for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes build on RISC-V with glibc 2.34+.
The main cause is that since glibc 2.34, there is no need to pass a
-pthreadto usestd::thread, butstd::atomicwon't work without one of-pthreadand-latomicflag on RISC-V.std::atomicis referenced in fileqcoro/task.hasstd::atomic<bool> QCoro::detail::TaskPromiseBase::mResumeAwaiterandstd::atomic<bool> QCoro::detail::TaskPromiseBase::mDestroyHandle. It's also referenced intests/testhttpserver.hso I linked network tests againstlibatomic, too.This patch is tested on rv64gc(qemu).