Fix early return in QCoro::waitFor#46
Merged
danvratil merged 1 commit intoqcoro:mainfrom Jan 26, 2022
Merged
Conversation
Contributor
danvratil
requested changes
Jan 26, 2022
Collaborator
danvratil
left a comment
There was a problem hiding this comment.
Good catch, thank you!
Would you mind adding a testcase for QCoro::waitFor() with an early-return coroutine to tests/task.cpp? There are already some testWaitFor* functions, so just add a variation with an already-finished coroutine, please.
Calling exit() on a QEventLoop that hasn't even started does nothing: it will also not prevent it from being started on exec().
danvratil
approved these changes
Jan 26, 2022
Collaborator
|
Awesome, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling exit() on a QEventLoop that hasn't even started does nothing:
it will also not prevent it from being started on exec().