Merged
Conversation
7d4799b to
c4e6d77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keybindings config flag
Description
This PR introduces a new feature that allows users to configure the keybindings of the TUI through the
.dblab.yamlfile.A new flag
--keybindings(or-k) has been added to the CLI. When this flag is used, the application will load the keybindings from the configuration file.The
README.mdanddocs/usage.mdfiles have been updated to document this new feature.The purpose of this change is to separate the connection config from the key bindings, so that, the user does not have to relay on the --config flag every time new keybindings values needs to be used.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
make runto start the application with the custom keybindings..dblab.yamlfile are being used.go test ./...to run the test suite.Checklist: