Fix ssh connection through the config file#273
Merged
danvergara merged 3 commits intomainfrom Oct 17, 2025
Merged
Conversation
25ec610 to
5bace87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix config file parsing for the ssh tunnel
Description
As reported in #270, dblab was not parsing the ssh tunnel configuration from the
.dblab.yamlconfig file.The reason was that the Database struct did not have fig struct tags for the ssh related fields. So, the fields reported on the README.md file were not being picked up by fig. The fix was actually adding the missing struct tags and proper testing for the ssh tunnel configuration.
Documentation files were updated too, to reflect the changes since some fields were not being documented.
Fixes #270
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The config package has a test suite, it was updated to validate the new fix.
Checklist: