Skip to content

Fix ssh connection through the config file#273

Merged
danvergara merged 3 commits intomainfrom
fix-ssh-config-file
Oct 17, 2025
Merged

Fix ssh connection through the config file#273
danvergara merged 3 commits intomainfrom
fix-ssh-config-file

Conversation

@danvergara
Copy link
Copy Markdown
Owner

@danvergara danvergara commented Oct 14, 2025

Fix config file parsing for the ssh tunnel

Description

As reported in #270, dblab was not parsing the ssh tunnel configuration from the .dblab.yaml config file.

The reason was that the Database struct did not have fig struct tags for the ssh related fields. So, the fields reported on the README.md file were not being picked up by fig. The fix was actually adding the missing struct tags and proper testing for the ssh tunnel configuration.

Documentation files were updated too, to reflect the changes since some fields were not being documented.

Fixes #270

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The config package has a test suite, it was updated to validate the new fix.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@danvergara danvergara marked this pull request as ready for review October 14, 2025 22:36
@danvergara danvergara changed the title Fix ssh config file Fix ssh connection through the config file Oct 14, 2025
@danvergara danvergara merged commit ded887b into main Oct 17, 2025
4 checks passed
@danvergara danvergara deleted the fix-ssh-config-file branch October 17, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config file with SSH tunnel fails while equivalent command-line arguments works

1 participant