Merged
Conversation
…nvironment to play with
…tunnel connection
rkgarcia
approved these changes
Jan 4, 2025
Collaborator
rkgarcia
left a comment
There was a problem hiding this comment.
This is an excellent feature!!!
mhammerly
reviewed
Jan 6, 2025
| return nil, err | ||
| } | ||
|
|
||
| defer sshConfig.Close() |
There was a problem hiding this comment.
will this result in the ssh tunnel closing before the application closes?
Owner
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH tunnel support
Description
This PR adds support for SSH Tunnel as requested many times in #205. It adds 6 new flags to the cli tool to perform the connection.
e.g.
This change only adds support for
MySQLandPostgres, more to come later.Fixes #205
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
A new docker compose file has been added to the development environment, adding a service called
ssh, withubuntu-sshdbeing its underlying base image to act as the ssh server to test the connection against.Also, a mock ssh server has been added to the test suite, to validate the use of the private key file as authentication method.
Checklist: