Conversation
…#497 - default build type to Release - set -DHIDDEN properly - pass .c files to compiler in same order - on linux/bsd, link libz.so with -lc explicitly (as Makefile.in does, but why?) - output same libz.pc and zconf.h as Make
ci/pkgcheck.sh: verify make and cmake install same bits, and that running configure/make doesn't try to reference wrong zconf.h.
Also don't assume there will only be one option.
This lets the Linux build upload results for both tests (example and example64).
The choice of output formats used to be intertwined with whether to terminate on first failure. New default is to not terminate on first failure, regardless of output formats; use --fail_fast if you want to stop the test on the first failure.
1a21f13 to
eb3077a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes madler#497 and madler#499