Return the HTTP error response body when a request fails#28
Merged
danielrbrowne merged 3 commits intomasterfrom Apr 1, 2021
Merged
Return the HTTP error response body when a request fails#28danielrbrowne merged 3 commits intomasterfrom
danielrbrowne merged 3 commits intomasterfrom
Conversation
- Adds a 'errorResponseBody' associated value to the 'failedResponse' case of 'APIotaClientError'. - Adds 'ErrorResponse' associated type on 'APIotaCodableEndpoint'. - Renames 'Response' associated type to 'SuccessResponse' on 'APIotaCodableEndpoint'.
- This handles the case when the OS cannot even send the URLRequest to the server at all due to a OS error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
errorResponseBodyassociated value to thefailedResponsecase ofAPIotaClientError.ErrorResponseassociated type onAPIotaCodableEndpoint.Responseassociated type toSuccessResponseonAPIotaCodableEndpoint.