Skip to content

Add Github workflow to automatically build#1302

Merged
danielkrupinski merged 1 commit intomasterfrom
unknown repository
Mar 26, 2020
Merged

Add Github workflow to automatically build#1302
danielkrupinski merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Mar 23, 2020

Hi

This patch adds a Github workflow that automatically builds Osiris when changes are pushed or any pull request is created. This is a great way to weed out low quality pull requests. If you want, you can even configure the workflow to automatically upload a compiled DLL to https://github.com/danielkrupinski/Osiris/releases.

@ghost ghost changed the title Add Github workflow to automatically compile Add Github workflow to automatically build Mar 23, 2020
@notaila
Copy link
Copy Markdown
Contributor

notaila commented Mar 24, 2020

It just builds the dll when some change is made and auto uploaded

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 24, 2020

sorry for being retarded, but what exactly do I have to do to make this work? haha, great commit nontheless

You don't have to do anything, the build is done automatically on a GitHub server.

image

Every time changes are pushed, GitHub will automatically compile Osiris to make sure the commit didn't completely break anything. You can also view the compiler output on GitHub if you want to look for warning messages.

You will also be able to view detailed information for each build in the Actions tab. (example: https://github.com/robootgit/Osiris/actions)

It just builds the dll when some change is made and auto uploaded

Correction: This commit doesn't add auto-upload. It wouldn't be difficult to add, but that decision should be up to danielkrupinski.

@rafalohaki
Copy link
Copy Markdown

+1

1 similar comment
@ghost
Copy link
Copy Markdown

ghost commented Mar 25, 2020

+1

@danielkrupinski danielkrupinski self-requested a review March 25, 2020 22:21
@danielkrupinski danielkrupinski merged commit 608bde5 into danielkrupinski:master Mar 26, 2020
@danielkrupinski
Copy link
Copy Markdown
Owner

Thanks! Let's see how it works out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants