Calling SyscallN directly when dealing with pointer-pointers#42
Merged
danieljoos merged 2 commits intomasterfrom May 15, 2023
Merged
Calling SyscallN directly when dealing with pointer-pointers#42danieljoos merged 2 commits intomasterfrom
SyscallN directly when dealing with pointer-pointers#42danieljoos merged 2 commits intomasterfrom
Conversation
085fd86 to
e1519b6
Compare
e1519b6 to
68f44ad
Compare
mislav
approved these changes
May 15, 2023
mislav
left a comment
There was a problem hiding this comment.
Thank you! I could not reproduce the original bug with this patch applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is trying to address #32 by calling
syscall.SyscallNdirectly when dealing with pointer-pointers.With that, the Go runtime seems to keep the given pointer alive.
It also moves the required Go version up to
1.18!