Merged
Conversation
efcd1b5 to
059628e
Compare
Contributor
|
@danieljoos ptal 🤗 |
danieljoos
reviewed
Aug 20, 2021
| return syscall.StringToUTF16(str) | ||
| res, err := syscall.UTF16FromString(str) | ||
| if err != nil { | ||
| return []uint16{} |
Owner
There was a problem hiding this comment.
I guess this is a slight change in behavior. The old implementation would have panic'ed.
New solution is better.
danieljoos
approved these changes
Aug 20, 2021
Owner
danieljoos
left a comment
There was a problem hiding this comment.
This is awesome.
Thank you very much for this contribution.
Owner
|
Not sure about these failing builds. Is there something missing in the workflow config? |
29ac408 to
5bb5bb3
Compare
Contributor
Author
|
@danieljoos Should work now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
syscallpackage to use thegolang.org/x/sysone.As stipulated in https://pkg.go.dev/syscall:
Also
utf16PtrToStringhas been moved to the native golang.org/x/sys/windows#UTF16PtrToString.In addition I've updated the workflow to use a matrix against Go 1.14, 1.15, 1.16, 1.17 and also push coverage results to Codacy. The workflow
godev.ymlhas been added to be able to automatically refreshpkg.go.devdoc on new release.Dependabot has also been added to keep dependencies up to date (gomod and github actions).
Finally, some fancy badges and move to
pkg.go.devfor docs.If you wish I can break this down into several PRs.