Add support for irreversible-delete#945
Conversation
|
Nice, I just hit this limitation today and was going to report a bug! |
|
Hi @wescande, thanks for this and I'm sorry I've been slow to review this one. It looks really clean and well-tested -- I'll look properly soon. |
|
I notice this allow to resolve #128 (even if it wasn't done for it initially) |
dandavison
left a comment
There was a problem hiding this comment.
Great! Couple of questions -- sorry again for being so slow this month.
Awesome, yes please feel free to remove it in this PR if convenient. |
Fix dandavison#128 Add support for `git diff -D` (aka irreversible delete) The patch is adding a title for removed file, even when there is no file content in the diff output Without the patch, there was no output related to the file at all
cf493f4 to
ea718dd
Compare
|
Excellent, thanks very much for this work @wescande, and thanks for the extra refactor you did there. If you'd like to do any follow-up refactoring that would be very welcome of course. |
Add support for
git diff -D(aka irreversible delete)The patch is adding a title for removed file, even when there is no file content in the diff output
Without the patch, there was no output related to the file at all
A image is better than a thousand word: wrong output on the left:x:, Better output on the right :heavy_check_mark:
