Fix hyperlink absolute paths#939
Merged
Merged
Conversation
47298b1 to
e106a5b
Compare
This was referenced Feb 8, 2022
0df3b85 to
9ed3672
Compare
No coverage?
- File hyperlink - Hunk header hyperlink - Line number hyperlink
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few bugs causing hyperlinks to have an incorrect target path -- related to the folllowing:
--relativeflag ordiff.relativesettingrelative-pathsoptionAn interesting fact is that when delta is invoked by git, the directory associated with the delta process is the repo root dir, even if delta is started in a deeper dir in the repo (this can be seen by doing
git -c core.pager=pwd show).This PR is an attempt to make everything correct. Here's how delta should behave:
relative-pathsoption is active, all relative paths displayed to the user should be correct from the user's current directory (so that they can becat'd, clicked on in terminal emulators that support that such as VSCode's, etc)diff.relativeis enabled or not