Skip to content

Update docs to make 3 basic configs match#2013

Closed
injust wants to merge 2 commits into
dandavison:mainfrom
injust:main
Closed

Update docs to make 3 basic configs match#2013
injust wants to merge 2 commits into
dandavison:mainfrom
injust:main

Conversation

@injust

@injust injust commented Jul 13, 2025

Copy link
Copy Markdown
Contributor

Defaulting to auto light/dark detection is the smarter choice here. Besides, the commands below omit the delta.dark = true setting.

The basic config appears in 3 places, so make them match, to consistently de-emphasize auto-detection of colors.

@injust injust changed the title Update README to use auto light/dark detection by default Update docs to use auto light/dark detection by default Jul 13, 2025
@dandavison

Copy link
Copy Markdown
Owner

Hi @injust, I believe we initially encouraged auto-detection in the docs, and I subsequently back-pedalled a bit: 1fb6f99 I didn't do a good job of linking that commit to an issue but I suspect it's one of the ones where the latency associated with the terminal I/O is huge on Windows.

@injust

injust commented Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

I see, that makes sense. In that case, since the basic config appears in 3 places, I'll change the PR to make those match.

(Also turns out the color auto-detection doesn't apply to me because I use Catppuccin, and what I actually need is #1678.)

@injust injust changed the title Update docs to use auto light/dark detection by default Update docs to make 3 basic configs match Jul 15, 2025
@injust

injust commented Jan 12, 2026

Copy link
Copy Markdown
Contributor Author

@dandavison Gentle ping, these docs changes should be good to merge.

@injust

injust commented Feb 22, 2026

Copy link
Copy Markdown
Contributor Author

Closing due to inactivity

@injust injust closed this Feb 22, 2026
@dandavison

Copy link
Copy Markdown
Owner

Sorry about that @injust! The changes look great and are much appreciated. If you'd like to reopen the PR I'll merge; but if I don't hear back in a few days I'll commit your changes anyway.

It's certainly true that I haven't found time for delta PR and issue maintenance recently. (On the plus side, delta is stable and used by lots of people). But sorry that it's resulting in contributions being ignored.

@injust

injust commented Feb 22, 2026

Copy link
Copy Markdown
Contributor Author

Probably easiest for you to commit the changes. I deleted my fork when I was cleaning up old repos, and I can't restore it without paying for GitHub Pro (wtf GitHub?)

Thanks for the great tool; delta has become an invaluable part of my workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants