Skip to content

🐛 delta rg pager is not exiting on q #1919

@dandavison

Description

@dandavison

To repro, in the delta git repo, issue

LESS= ./target/release/delta rg match

Since there are multiple pages of matches, this will result in paging via less. I expect q to exit the pager and give a shell prompt.

What I find instead is that q exits the pager, but does not give a shell prompt.

When I first issue the search command and the pager is active, the process tree looks like

delta(main) pstree 71721
-+= 71721 dan ./target/release/delta rg match
 |--- 71737 dan less -FR
 \--- 71749 dan rg --json match

After entering q, the pager content disappears and I'm left with a blank screen, which is not offering a shell prompt. The process tree looks like

delta(main) pstree 71721
-+= 71721 dan ./target/release/delta rg match
 |--- 71737 dan <defunct>
 \--- 71749 dan rg --json match

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions