Skip to content

🐛 Paths not updated for a diff of modified binary file #1621

@imbrish

Description

@imbrish

I have a commit in which a binary file is modified, and a new text file is added.

If I diff only the binary file, everything is good:

diff --git a/meta/archive.zip b/meta/archive.zip
index 00de669..d47cd84 100644
Binary files a/meta/archive.zip and b/meta/archive.zip differ

image

But if I diff it together with the text file, the label for the modified binary file becomes incorrect:

diff --git a/meta/added.txt b/meta/added.txt
new file mode 100644
index 0000000..b5eab54
--- /dev/null
+++ b/meta/added.txt
@@ -0,0 +1 @@
+This file was not here before.
diff --git a/meta/archive.zip b/meta/archive.zip
index 00de669..d47cd84 100644
Binary files a/meta/archive.zip and b/meta/archive.zip differ

image

I have built delta from the source, commit e208f4e, but tested also for tag 0.16.5 (03f1569) with the same outcome.

May be related to #96 and #1502.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions