Always perform layout after minimize start and end#1177
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the minimize window transforms to trigger workspace layouts and improves type consistency.
- Changed
SkipDoLayoutfromtruetofalsein bothMinimizeWindowStartTransformandMinimizeWindowEndTransformto ensure layouts are triggered when windows are minimized/unminimized - Updated
MinimizeWindowStartTransformto use theWorkspaceIdtype alias instead ofGuidfor consistency - Enhanced tests to verify layout behavior occurs correctly, including setting up monitors and using
CustomAssert.Layoutassertions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Whim/Store/WorkspaceSector/Transforms/MinimizeWindowStartTransform.cs | Changed parameter type from Guid to WorkspaceId type alias and set SkipDoLayout to false to trigger layouts |
| src/Whim/Store/WorkspaceSector/Transforms/MinimizeWindowEndTransform.cs | Set SkipDoLayout to false to trigger layouts when windows are unminimized |
| src/Whim.Tests/Store/WorkspaceSector/Transforms/MinimizeWindowStartTransformTests.cs | Updated tests to verify layout operations occur by adding monitor setup, configuring mock engine layouts, and using CustomAssert.Layout |
| src/Whim.Tests/Store/WorkspaceSector/Transforms/MinimizeWindowEndTransformTests.cs | Updated tests to verify layout behavior - one test confirms no layout when workspace unchanged, another confirms layout when workspace changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Whim.Tests/Store/WorkspaceSector/Transforms/MinimizeWindowEndTransformTests.cs
Outdated
Show resolved
Hide resolved
…EndTransformTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Isaac Daly <isaac.daly@outlook.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
=======================================
Coverage 80.09% 80.09%
=======================================
Files 278 278
Lines 12718 12718
Branches 1469 1469
=======================================
Hits 10187 10187
Misses 2361 2361
Partials 170 170 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that layout operations are triggered appropriately after minimizing a window, correcting the handling of layout execution in the minimize window transforms.
Closes #1175.