Expose window processors to C# scripts#1155
Merged
Conversation
1 task
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the window processor management system to C# scripts by making IWindowProcessorManager available through the IContext. This enables custom scripting to add or remove window processors at runtime.
- Refactored
WindowProcessorManagerto implement a public interface with a keyed dictionary for processor management - Added unique string identifiers to existing window processors for dictionary-based lookup
- Exposed
IWindowProcessorManagerthrough theIContextinterface for scripting access
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
WindowEventListener.cs |
Removed local processor manager in favor of context-provided instance |
WindowProcessorManager.cs |
Converted to implement public interface with keyed processor dictionary |
TeamsWindowProcessor.cs |
Added static Id property for processor identification |
IWindowProcessorManager.cs |
New public interface defining processor management contract |
IWindowProcessor.cs |
Updated documentation and removed redundant public modifiers |
FirefoxWindowProcessor.cs |
Added static Id property for processor identification |
IContext.cs |
Added WindowProcessorManager property to expose processor management |
Context.cs |
Initialized WindowProcessorManager instance in constructor |
troubleshooting.md |
Added documentation about scripting access to processor management |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
==========================================
- Coverage 80.22% 80.17% -0.06%
==========================================
Files 279 279
Lines 12730 12733 +3
Branches 1470 1470
==========================================
- Hits 10213 10209 -4
- Misses 2348 2354 +6
- Partials 169 170 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the
IWindowProcessorManagerthrough theIContext, to allow customization through scripting.IWindowProcessors have a staticIdstring field which is used to identify them. This can be used to add or remove them from theIWindowProcessorManager.ProcessorCreatorsdictionary.