Use a dropdown for active layout widget#1036
Use a dropdown for active layout widget#1036dalyIsaac merged 16 commits intodalyIsaac:mainfrom AndreiZhvaleuski:gh-665-layout-engine-dropdown-widget
Conversation
|
This looks awesome! A couple of thoughts after a brief first look: If you open the dropdown then click another window, the dropdown doesn't hide. If this isn't built into WinUI, you can hide the dropdown when the focused window changes.
After primarily using HTML and CSS, I find XAML somewhat infuriating so I sympathize with this. Screen.Recording.2024-09-27.222608.mp4Each item in the dropdown appears to have padding greater than the bar height - is it possible to trim this down? If not, no worries - I can make another issue and chuck it somewhere on the backlog. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
==========================================
- Coverage 80.58% 80.38% -0.21%
==========================================
Files 283 283
Lines 12418 12495 +77
Branches 1434 1440 +6
==========================================
+ Hits 10007 10044 +37
- Misses 2226 2267 +41
+ Partials 185 184 -1 ☔ View full report in Codecov by Sentry. |
mainbranch.This PR fixes #665
Update the logic of the active layout widget to use a combo box element instead of a button. The logic itself is ready and works, but I'm not so good at styling XAML via resources, so need to see what are mmy options to make it look better.
This is how it looks now.
Closed state:
Opened state:
