Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dalek-cryptography/subtle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.4.0
Choose a base ref
...
head repository: dalek-cryptography/subtle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.4.1
Choose a head ref
  • 12 commits
  • 3 files changed
  • 3 contributors

Commits on Dec 17, 2020

  1. Configuration menu
    Copy the full SHA
    e84edda View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82e3368 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Configuration menu
    Copy the full SHA
    792c385 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Update src/lib.rs

    Co-authored-by: daxpedda <daxpedda@gmail.com>
    Centril and daxpedda authored Jun 24, 2021
    Configuration menu
    Copy the full SHA
    3b5afc0 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Configuration menu
    Copy the full SHA
    8a70fff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d08ffd0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5e7a69a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e58fced View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bda4a41 View commit details
    Browse the repository at this point in the history
  6. Fix builds by removing include_str!(docs).

    The latest rust nightlies and beta (at stable version 1.55) include a
    change from
    
        #![cfg_attr(feature = "nightly", feature(external_doc))]
        #![cfg_attr(feature = "nightly", doc(include = "../README.md"))]
    
    to removing `feature(external_doc)` and also changing the syntax of
    the second line to
    
        #![cfg_attr(feature = "nightly", doc = include_str!("../README.md"))]
    
    However.  `include_str!` is stable currently, but the syntax of `doc =
    ` is expressly disallowed.  This gives me four options:
    
     1. Don't build documentation (bad)
     2. Copy-pasta README.md into src/lib.rs (also bad)
     3. Support only beta/nightly but not stable (completely untennable
        for a crate with ~14 million downloads)
     4. Support only stable but not beta/nightly (also untennable)
    
    Further, waiting for this to be "fixed" by its inclusion in stable
    Rust in about a week means that our MSRV increases from 1.41 to 1.56,
    with no changes to actual code (other than how to build documentation)
    at all, which seems quite unfriendly to downstream dependents who are
    pinning their rust versions for whatever reason.
    
    So, sadly, it seems the most friendly fix is to copy-pasta our
    README.md into the codebase.
    
    (cf. rust-lang/rust#44732,
          rust-lang/rust#82539)
    isislovecruft committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    8351f02 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    90af5f2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b4b070c View commit details
    Browse the repository at this point in the history
Loading