-
Notifications
You must be signed in to change notification settings - Fork 90
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: dalek-cryptography/subtle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.4.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: dalek-cryptography/subtle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.4.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 12 commits
- 3 files changed
- 3 contributors
Commits on Dec 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e84edda - Browse repository at this point
Copy the full SHA e84eddaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82e3368 - Browse repository at this point
Copy the full SHA 82e3368View commit details
Commits on Jun 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 792c385 - Browse repository at this point
Copy the full SHA 792c385View commit details
Commits on Jun 24, 2021
-
Co-authored-by: daxpedda <daxpedda@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3b5afc0 - Browse repository at this point
Copy the full SHA 3b5afc0View commit details
Commits on Jul 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8a70fff - Browse repository at this point
Copy the full SHA 8a70fffView commit details -
Configuration menu - View commit details
-
Copy full SHA for d08ffd0 - Browse repository at this point
Copy the full SHA d08ffd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e7a69a - Browse repository at this point
Copy the full SHA 5e7a69aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e58fced - Browse repository at this point
Copy the full SHA e58fcedView commit details -
Configuration menu - View commit details
-
Copy full SHA for bda4a41 - Browse repository at this point
Copy the full SHA bda4a41View commit details -
Fix builds by removing include_str!(docs).
The latest rust nightlies and beta (at stable version 1.55) include a change from #![cfg_attr(feature = "nightly", feature(external_doc))] #![cfg_attr(feature = "nightly", doc(include = "../README.md"))] to removing `feature(external_doc)` and also changing the syntax of the second line to #![cfg_attr(feature = "nightly", doc = include_str!("../README.md"))] However. `include_str!` is stable currently, but the syntax of `doc = ` is expressly disallowed. This gives me four options: 1. Don't build documentation (bad) 2. Copy-pasta README.md into src/lib.rs (also bad) 3. Support only beta/nightly but not stable (completely untennable for a crate with ~14 million downloads) 4. Support only stable but not beta/nightly (also untennable) Further, waiting for this to be "fixed" by its inclusion in stable Rust in about a week means that our MSRV increases from 1.41 to 1.56, with no changes to actual code (other than how to build documentation) at all, which seems quite unfriendly to downstream dependents who are pinning their rust versions for whatever reason. So, sadly, it seems the most friendly fix is to copy-pasta our README.md into the codebase. (cf. rust-lang/rust#44732, rust-lang/rust#82539)Configuration menu - View commit details
-
Copy full SHA for 8351f02 - Browse repository at this point
Copy the full SHA 8351f02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90af5f2 - Browse repository at this point
Copy the full SHA 90af5f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4b070c - Browse repository at this point
Copy the full SHA b4b070cView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 2.4.0...2.4.1