fix: Fix missing params being propagated to vast-resolving event#503
Merged
clementFrancon merged 1 commit intomasterfrom Mar 17, 2026
Merged
fix: Fix missing params being propagated to vast-resolving event#503clementFrancon merged 1 commit intomasterfrom
clementFrancon merged 1 commit intomasterfrom
Conversation
ZacharieTFR
approved these changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves VAST wrapper resolution telemetry by propagating additional wrapper context into the fetch layer (so VAST-resolving has richer debugging information) and aligns the unit tests with the updated fetch parameters.
Changes:
- Pass
wrapperDepth,previousUrl, andwrapperAdintofetchVASTduring wrapper unwrapping. - Update
spec/vast_parser.spec.jsexpectations to assert the new parameters are provided tofetchVAST.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/parser/vast_parser.js |
Propagates wrapper context (wrapperDepth, previousUrl, wrapperAd) to fetchVAST when resolving wrappers. |
spec/vast_parser.spec.js |
Updates wrapper-resolution tests to expect the additional fetchVAST call parameters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+401
to
+403
| wrapperDepth, | ||
| previousUrl, | ||
| wrapperAd: ad, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request enhances the handling and testing of VAST wrapper ads by introducing additional parameters to the parsing logic and updating the related test cases. The main improvements focus on passing more context when parsing wrappers, which helps with debugging and data merging.
Enhancements to VAST wrapper parsing:
wrapperDepth,previousUrl, andwrapperAdparameters to the call tofetchVastXmlin theVASTParserclass to provide more context during wrapper parsing.Test coverage improvements:
spec/vast_parser.spec.jsto expect the new parameters (wrapperDepth,previousUrl,wrapperAd) when verifying calls tofetchVastXml, ensuring tests accurately reflect the enhanced parsing logic. [1] [2]