Skip to content

Add ability to pass extra options to fetch method#495

Merged
ZacharieTFR merged 1 commit intodailymotion:masterfrom
Janjiran:feature/fetch-options
Jun 10, 2025
Merged

Add ability to pass extra options to fetch method#495
ZacharieTFR merged 1 commit intodailymotion:masterfrom
Janjiran:feature/fetch-options

Conversation

@Janjiran
Copy link
Copy Markdown
Contributor

@Janjiran Janjiran commented Apr 22, 2025

Description

Enhance VAST client options to include fetchOptions for custom request body fetchingOptions like headers and caching. This is helpful when you want to pass basic params but don't want to write a whole urlHandler.
Update tests to validate fetchOptions integration and ensure existing timeout and withCredentials settings are preserved.

Type

  • Breaking change
  • Enhancement
  • Fix
  • Documentation
  • Tooling

@Janjiran Janjiran changed the title [client][test] Add ability to pass extra options to fetch method Add ability to pass extra options to fetch method Apr 29, 2025
@Janjiran
Copy link
Copy Markdown
Contributor Author

Hi, can somebody take a look at this PR? It would be great to have this option :) I'm happy to update it further if there are any issues.

Copy link
Copy Markdown
Contributor

@ZacharieTFR ZacharieTFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution !

@ZacharieTFR ZacharieTFR merged commit 5fe03d6 into dailymotion:master Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants