Fix issues/483 and add a basic Node example#484
Fix issues/483 and add a basic Node example#484clarissedmn merged 8 commits intodailymotion:masterfrom
Conversation
ZacharieTFR
left a comment
There was a problem hiding this comment.
Hello, thank you for your contribution, it is much appreciated! I've left a few comments
There was a problem hiding this comment.
Please do not push the dist, we will do it during the next release 😉
There was a problem hiding this comment.
oh... my bad, I deleted them :P Let me restore the original dist folder
There was a problem hiding this comment.
Yeap, now the dist folder has no changes. Solved in commit 2b48c61
Example Node: re-use the same information than the root package Co-authored-by: Zac <ztaifour@gmail.com>
|
Thank you @ZacharieTFR, I made those changes |
ZacharieTFR
left a comment
There was a problem hiding this comment.
As you moved the example folder and added the node, can you update the readme aswell ?
Line 18 in d6420de
Fix: The EOF was missing Co-authored-by: Zac <ztaifour@gmail.com>
I changed this text in the last commit:
@ZacharieTFR Let me know what you think. |
|
Awesome!! just FYI: we are using this library in this project https://github.com/montevideo-tech/vast-2-sgai/ .A basic VAST-2-SGAI (VAST to Asset List and ListMPD) opens-ource microservice :) |
Description
Issue
#483
Type