Skip to content

Add support for non supported vast error#481

Merged
ZacharieTFR merged 3 commits intomasterfrom
fix-wrong-error
Nov 26, 2024
Merged

Add support for non supported vast error#481
ZacharieTFR merged 3 commits intomasterfrom
fix-wrong-error

Conversation

@ZacharieTFR
Copy link
Copy Markdown
Contributor

Description

  • vast client will now trigger error code 102 VAST version of response not supported. if it parse a outdated VAST version (only 1.0 for now)
  • Fix error 303 No VAST response after one or more Wrappers not being triggered when a wrapper containing a <Creative> without mediafile (e.g only with a <CompanionAds> inside) does not result in a VAST response.

Issue

#476

Type

  • Breaking change
  • Enhancement
  • Fix
  • Documentation
  • Tooling

@ZacharieTFR ZacharieTFR self-assigned this Nov 12, 2024
Copy link
Copy Markdown
Contributor

@clarissedmn clarissedmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Comment thread docs/api/1.x/parser.md Outdated

* VAST error `101`: VAST schema validation error.

* VAST error `102`: VAST version of response not supported.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* VAST error `102`: VAST version of response not supported.
* VAST error `102`: VAST response version not supported.

Copy link
Copy Markdown
Contributor Author

@ZacharieTFR ZacharieTFR Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I edited the wrong file, this documentation is for old versions 1.x. I moved it to the correct one. The error description comes from IAB https://wiki.iabtechlab.com/index.php?title=VAST_Error_Code_Troubleshooting_Matrix
image

Copy link
Copy Markdown
Contributor

@clementFrancon clementFrancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Comment thread spec/samples/outdated-vast.xml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants