internal/packaging/container_init_test.go (1)

126-129: ⚡ Quick win

Strengthen coverage by asserting DAG mount count per file.

This currently proves “no :ro + at least one writable mount,” but it won’t catch accidental mount removal from some services in compose.prod.yaml. Assert expected occurrence counts per file.

🔧 Suggested hardening

 func TestDockerComposeDAGMountsStayWritable(t *testing.T) {
 	t.Parallel()

-	files := []string{
-		"deploy/docker/compose.minimal.yaml",
-		"deploy/docker/compose.prod.yaml",
-	}
+	expectedMountCounts := map[string]int{
+		"deploy/docker/compose.minimal.yaml": 1,
+		"deploy/docker/compose.prod.yaml":    4,
+	}

 	root := repoRoot(t)
-	for _, file := range files {
+	for file, expectedCount := range expectedMountCounts {
 		t.Run(file, func(t *testing.T) {
 			t.Parallel()

 			content := readFile(t, filepath.Join(root, file))
 			require.NotContains(t, content, "./dags:/var/lib/dagu/dags:ro", "%s must keep the DAG directory writable for first-run seeding and DAG edits", file)
 			require.Contains(t, content, "./dags:/var/lib/dagu/dags", "%s must mount the local DAG directory", file)
+			require.Equal(t, expectedCount, strings.Count(content, "./dags:/var/lib/dagu/dags"), "%s must keep DAG mounts on all expected services", file)
 		})
 	}
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@internal/packaging/container_init_test.go` around lines 126 - 129, The test
should also assert the expected number of DAG mounts per file to catch
accidental removals: after reading content := readFile(t, filepath.Join(root,
file)) use strings.Count(content, "./dags:/var/lib/dagu/dags") and
require.Equal(t, expectedCount, count, "%s must contain %d DAG mounts", file,
expectedCount) (and optionally assert strings.Count(content,
"./dags:/var/lib/dagu/dags:ro") == 0) — update the test where
require.Contains/NotContains are used to compute count via strings.Count and
compare to the expected occurrence for that compose file.