test: cover distributed queued runtime params#2242
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds test infrastructure and tests to verify that runtime parameters enqueued on a DAG run are preserved through the queued state and propagated to distributed task retry dispatch and node execution. Changes span test fixture helpers, unit tests, and integration tests. ChangesQueued Runtime Parameters Propagation in Distributed Retries
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
No issues found across 3 files
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
Re-trigger cubic
Summary
Testing
Summary by cubic
Add tests to verify queued runtime params propagate end-to-end in distributed runs, including retries. Adds a params-aware enqueue helper and asserts params flow into coordinator tasks, DAGRun status, and worker outputs.
Written for commit 5b7a51d. Summary will update on new commits.
Summary by CodeRabbit