Skip to content

refactor(api): remove DAG run history renaming from RenameDAG endpoint#1442

Merged
yohamta0 merged 1 commit into
mainfrom
renaming-dag-keep-runs
Dec 4, 2025
Merged

refactor(api): remove DAG run history renaming from RenameDAG endpoint#1442
yohamta0 merged 1 commit into
mainfrom
renaming-dag-keep-runs

Conversation

@yohamta0

@yohamta0 yohamta0 commented Dec 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Improved DAG renaming operation by preventing data loss.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Walkthrough

The RenameDAG function in the DAG API service has been simplified by removing pre-rename metadata validation, post-rename metadata retrieval, and associated DAG runs history rename operations. The function now performs only the core rename operation and returns the result.

Changes

Cohort / File(s) Summary
DAG rename simplification
internal/service/frontend/api/v2/dags.go		 Removed pre- and post-rename DAG metadata fetching and DAG runs history rename operations from the RenameDAG function; now only performs the core rename operation

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Verify removal implications: Ensure that pre-rename metadata validation was not critical for data integrity or system correctness
  • Assess DAG runs history impact: Confirm that skipping DAG runs history updates aligns with product requirements and doesn't create data inconsistencies
  • Check downstream dependencies: Review calling code to ensure it doesn't depend on the removed metadata validation or history updates

Poem

🐰 A DAG rename, once tangled and long,
Now streamlined and nimble, where focus belongs—
No ghosts of old metadata haunting the way,
Just swap and move forward, simplicity's play! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the main change: removal of DAG run history renaming from the RenameDAG endpoint, which matches the file summary showing deletion of history-rename functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch renaming-dag-keep-runs
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f622796 and c402589.

📒 Files selected for processing (1)
  • internal/service/frontend/api/v2/dags.go (0 hunks)
💤 Files with no reviewable changes (1)
  • internal/service/frontend/api/v2/dags.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Test on ubuntu-latest

Comment @coderabbitai help to get the list of available commands and usage tips.

@yohamta0 yohamta0 merged commit e076056 into main Dec 4, 2025
5 checks passed
@yohamta0 yohamta0 deleted the renaming-dag-keep-runs branch December 4, 2025 11:06
@codecov

codecov Bot commented Dec 4, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.94%. Comparing base (e75d14f) to head (c402589).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1442   +/-   ##
=======================================
  Coverage   59.94%   59.94%           
=======================================
  Files         187      187           
  Lines       21022    21022           
=======================================
  Hits        12602    12602           
  Misses       7106     7106           
  Partials     1314     1314

see 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f622796...c402589. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot mentioned this pull request Dec 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yohamta0