Fix: No new resolver crash with partially resolved datatype update expressions#5440
Merged
MikaelMayer merged 25 commits intoJun 14, 2024
Merged
Conversation
RustanLeino
previously approved these changes
May 23, 2024
RustanLeino
left a comment
Collaborator
There was a problem hiding this comment.
The fix itself looks good. For the if/switch refactoring, I only did a quick scan.
Comment on lines
+4
to
+8
| datatype S = S( | ||
| n:nat | ||
| ) { | ||
| function f():S { this } | ||
| function g():S { this.(n := 0).f() } |
Collaborator
There was a problem hiding this comment.
This file contains the failing test in Issue #5365, right? If so, should the name of the file reflect this?
RustanLeino
previously approved these changes
May 24, 2024
…nullreferenceexception # Conflicts: # Source/DafnyCore/Resolver/PreType/PreTypeResolve.Expressions.cs
RustanLeino
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5331
Fixes #5365
The only part that fixes the issue is the last line end of the file PreTypeResolve.Expressions.cs, the rest is an automated conversion If/then/else to a switch statement that helped debugging and makes the code easier to maintain.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.