Revert "Feat rust operators (#5380)" (again)#5383
Merged
robin-aws merged 2 commits intoMay 1, 2024
Merged
Conversation
This reverts commit 0b629ea.
fabiomadge
approved these changes
Apr 30, 2024
Member
Author
|
Temporarily allowed administrators to merge without checks passing, because the osx unit tests were hitting flaky failures over and over, and this is a revert intended to unblock nightly anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0b629ea to fix failing nightly: https://github.com/dafny-lang/dafny/actions/runs/8896634004/job/24436389955
Unfortunately I approved #5380 before all of the deep tests had run, and because the extra checks aren't normally run for a PR unless it has the
run-deep-testslabel, they can't be required checks, so the PR was auto-merged even though several Windows runs timed out after 2 hours.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.