Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release #2859 +/- ##
========================================
Coverage 91.29% 91.29%
========================================
Files 283 283
Lines 10670 10672 +2
========================================
+ Hits 9741 9743 +2
Misses 677 677
Partials 252 252 ☔ View full report in Codecov by Sentry. |
Request.URL.Captures with Envoy ext_auth integration due to Request object reinitializationRequest.URL.Captures with Envoy ext_auth integration
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
closes #2858
Checklist
Description
This PR fixes an issue where captured values from URL path wildcards were not propagated through the pipeline when using the Envoy integration. The root cause was that the
URLobject was recreated on each access to theRequestobject, resetting itsCapturesmap. The fix ensures that the URL instance is created once and reused.