fix: Resolution of the request duration metric adjusted to make it meaningful#2954
Merged
fix: Resolution of the request duration metric adjusted to make it meaningful#2954
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release #2954 +/- ##
===========================================
- Coverage 91.20% 91.16% -0.04%
===========================================
Files 283 283
Lines 10705 10725 +20
===========================================
+ Hits 9763 9777 +14
- Misses 686 689 +3
- Partials 256 259 +3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
none
Checklist
Description
This PR makes the OTEL metric
http.server.request.duration(and its Prometheus-exported counterparthttp_server_request_duration_seconds) usable again, restoring the effective resolution that existed in v0.11.1-alpha prior to the migration to OpenTelemetry.The default OTEL histogram configuration uses a lowest bucket boundary of 5 ms, which is far too coarse for heimdall’s request latency characteristics (typically, P99 of requests complete well below 1 ms). That makes all sub-millisecond latencies collapse into a single bucket and renders percentile calculations (P50–P99) meaningless by obscuring latency regressions.
BEGIN_COMMIT_OVERRIDE
fix: Request duration metric resolution adjusted for sub-millisecond latencies (#2954)
END_COMMIT_OVERRIDE