fix: update PGP signing method to use clearsign format#172
Merged
dadav merged 1 commit intodadav:mainfrom Jan 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix plugin provenance signing
The
sign-plugin.shscript creates invalid provenance files that fail verification:Root Cause
The script manually added PGP headers (
-----BEGIN PGP SIGNED MESSAGE-----,Hash: SHA256), then usedgpg --detach-signto sign that content, then concatenated the result. This creates an invalid format where the signature includes the PGP headers themselves, causing hash algorithm conflicts.Solution
Use
gpg --clearsignwhich properly handles PGP clearsign format. This matches Helm's implementation (clearsign.Encode()).Changes
gpg --detach-signtogpg --clearsign