General: Refresh Play Store dashboard and add-profile screenshots#586
Merged
Conversation
Use AAP-connected mocks for the dark dashboard to showcase full connectivity badges (BLE + IRK + encrypted + AAP) and the ANC mode selector. Populate the add-profile preview with a demo name, model, and paired device. Add user-facing labels to the dashboard mock devices. Refactor BluetoothDevice2 so name/address are primary constructor fields, letting previews construct one without a real Android BluetoothDevice. Bump the screenshot test JVM heap to 4g — the smoke batch (42 renders) was hitting the test executor's default ceiling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Refreshed the Play Store dashboard and add-profile screenshots with more representative preview data:
Technical Context
labeltoMockPodDataProvider's dashboard mocks. The popup screenshot was unaffected because it usesgetLabel(context)which falls back to the model name; the dashboard card readsdevice.labeldirectly with?as the fallback.BluetoothDevice2soaddressandnameare primary constructor fields withinternal: BluetoothDevice?optional. Previews can now mock it without a real AndroidBluetoothDevice. Adjusted the six callers that need the wrapped Android handle (AapAutoConnectx4 with!!, two reflection calls inBluetoothManager2with explicit null bail-out).maxHeapSizeto 4g — the smoke batch (6 locales × 7 screens = 42 renders) was OOMing in layoutlib's image pool with the test executor's default heap.