Fix: Drop redundant explicit release-tag dispatch (App-token fires push trigger)#568
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Drops the explicit
gh workflow run release-tag.ymlstep fromrelease-prepare.yml. Since the prepare job now pushes with a GitHub App token (notGITHUB_TOKEN), the naturalon: push: tags: ['v*']trigger firesrelease-tag.ymlautomatically — the explicit dispatch was originally a workaround forGITHUB_TOKEN's trigger suppression and is now redundant.Without this, every release dispatched two duplicate
release-tag.ymlruns (one from the natural push trigger, one from the explicit dispatch), queued back-to-back via the concurrency group. The first release run (#25205749266) triggered exactly this.Technical Context
on: pushworkflow triggers — onlyGITHUB_TOKEN-driven pushes are suppressed by GitHubVerify gh auth and dispatch capabilitystep — its sole purpose was sanity-checking that the now-removed dispatch step would workcontents: read, actions: readto justcontents: read; dropped Job 1's job-levelGH_TOKENenv (noghcalls remain in Job 1)release-tag.yml(group: release-${{ github.ref_name }}) still protects against accidental duplicates if anyone manually dispatches the workflow at the same ref