Skip to content

Fix: Drop redundant explicit release-tag dispatch (App-token fires push trigger)#568

Merged
d4rken merged 1 commit into
mainfrom
fix/release-prepare-no-explicit-dispatch
May 1, 2026
Merged

Fix: Drop redundant explicit release-tag dispatch (App-token fires push trigger)#568
d4rken merged 1 commit into
mainfrom
fix/release-prepare-no-explicit-dispatch

Conversation

@d4rken

@d4rken d4rken commented May 1, 2026

Copy link
Copy Markdown
Member

What changed

Drops the explicit gh workflow run release-tag.yml step from release-prepare.yml. Since the prepare job now pushes with a GitHub App token (not GITHUB_TOKEN), the natural on: push: tags: ['v*'] trigger fires release-tag.yml automatically — the explicit dispatch was originally a workaround for GITHUB_TOKEN's trigger suppression and is now redundant.

Without this, every release dispatched two duplicate release-tag.yml runs (one from the natural push trigger, one from the explicit dispatch), queued back-to-back via the concurrency group. The first release run (#25205749266) triggered exactly this.

Technical Context

  • App-token pushes do fire on: push workflow triggers — only GITHUB_TOKEN-driven pushes are suppressed by GitHub
  • Removed Job 1's Verify gh auth and dispatch capability step — its sole purpose was sanity-checking that the now-removed dispatch step would work
  • Tightened Job 1 permissions from contents: read, actions: read to just contents: read; dropped Job 1's job-level GH_TOKEN env (no gh calls remain in Job 1)
  • Job 2's existing concurrency on release-tag.yml (group: release-${{ github.ref_name }}) still protects against accidental duplicates if anyone manually dispatches the workflow at the same ref

@d4rken d4rken merged commit d399a6d into main May 1, 2026
11 checks passed
@d4rken d4rken deleted the fix/release-prepare-no-explicit-dispatch branch May 1, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant