Fix: Avoid privileged endpoint when resolving release bot identity#567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes a 401 "JSON web token could not be decoded" error in the new App-token release flow. The
Resolve bot identitystep previously calledgh api /appto fetch the App's slug, but that endpoint requires a GitHub App JWT (signed with the private key) — not the installation access token the workflow has. Switching to the action's ownapp-slugoutput avoids the privileged endpoint entirely.Technical Context
actions/create-github-app-tokenaction exposesapp-slugas a step output; using it removes the need to query the API for itgh api /users/<slug>%5Bbot%5Dcall is fine — that endpoint accepts installation tokensaction.ymloutputs schema (token,installation-id,app-slug)Test plan
After merge, redispatch:
Expect Job 2's
Resolve bot identitystep to print outputs cleanly and the rest of Job 2 to push the bump + tag through the bypass.