Widget: Keep theme and transparency after device reboot#552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Widget theme settings (Dark/Light/Custom presets, background transparency, label visibility) were lost after rebooting the device. Previously, configured widgets reverted to "Material You" with full background opacity on the next boot. The selected device profile already survived reboot; now the rest of the configuration does too.
Closes #549
Technical Context
AppWidgetManager.getAppWidgetOptions(). Per AOSPAppWidgetServiceImpl.serializeAppWidget(...), only the five standardOPTION_APPWIDGET_*system keys are written toappwidgets.xml; arbitrary custom keys are silently dropped at boot. Universal Android behavior, not Samsung- or launcher-specific.WidgetSettings' own DataStore, which the system widget service does not touch.WidgetConfigunderwidget_config_<id>in the existingwidget_preferencesDataStore.dataStore.edit {}block as the write so a concurrent save cannot be overwritten by stale legacy data. The legacy options bundle is parsed via a newWidgetTheme.fromLegacyBundleOrNull()that returns null on a system-only bundle — avoiding a false "Material You + 255" migration read.getWidgetConfig(widgetId=15)returned the same values that were saved before the reboot.