Device: Revise AAP protocol notes on hearing-aid message#544
Merged
Conversation
|
The Band Edges command is also almost certainly not related to anything EQ. The bandcode semantics are likely those here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
No user-facing behavior change. Internal documentation update: comments in AAP protocol code that previously called message type
0x0053"Personal Mixing Engine?" now call it "Personal Medical Equipment" — the hearing-aid configuration for Apple's iOS 18.1+ AirPods Pro 2 hearing-aid feature.Technical Context
PME*(matches the Wireshark label; renaming on a still-hypothesis would churn call sites).AapSessionEngine's comment onSET_BAND_EDGES(0x0054) loses its "real EQ" parenthetical — that guess was anchored to the "Personal Mixing Engine" reading of PME and is no longer warranted.