Device: Show hardware, pending firmware, and bonded dates#543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The device info sheet (tap the info icon on the device settings card) now shows more information the app was already decoding but not displaying:
1.0.0)"Bonded" rather than "Paired" to avoid confusion with the current phone connection — in Bluetooth terminology, bonding is the persistent per-bud association.
Technical Context
buildList<DeviceDetailItem>inDeviceSettingsScreeninto a pure mapper (buildDeviceInfoDetailItems), unit-tested with 14 cases covering all branches — previously untestable because logic was mixed withstringResourcecalls inside aLazyColumnitemLocalConfiguration.current.locales[0]andZoneId.systemDefault()viaremember, so it follows the app-level locale rather than JVM defaultCachedDeviceStatedoes not serialize the new fields, so they disappear when the device is out of range. Matches existing Manufacturer-row behavior (also blanked from cache). Extending the cache was deferred —firmwareVersionPendingwould risk showing a stale staged update after reboot81.2675000075000000.6814) are too long to pair cleanly with BuildDeviceInfoBottomSheet.ktnow go through the sameDeviceInfoDetailsContentcomposable as the production sheet (previously hand-copiedInfoRowcalls, which silently drifted)