Fix: Accurate signal bars and stable connection icons#491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Technical Context
rssiQuality(pure linear, display only) andsignalQuality(composite with reliability + age, used for profile matching and sorting). The0.15filter still rejects -100 dBm noise.a102b032accidentally reduced the badge to two icons. NewDeviceConnectionBadgerenders four conditional icons and gives ENC its own lock glyph (previously shared the key icon).profileKeyStateonPodDevicedrives key/lock icons from the stableAppleDeviceProfileso a lost scan batch doesn't lose them;rssiQualityfalls back to1.0when AAP isREADY, since a healthy audio connection is proof the signal is fine. Rejected alternative: graduating off AAP message age — the channel is event-driven, so a quiet audio session can go minutes without a message. The BLE antenna icon stays honest — only shown when a live advertisement actually arrived.Review checklist
rssiQuality(display) vssignalQuality(matching) split —AppleFactory.kt:104(filter),TroubleShooterViewModel.kt:219(sorting), andBlePodMonitor.kt:114(sorting) must keep using the composite valuebleKeyStateprefersprofileKeyStatewhile the device is live, falls back to liveisIRKMatchfor anonymous BLE pods with no profile entryrssiQualityAAP fallback only triggers onREADY, not duringCONNECTING/HANDSHAKINGNONEforbleKeyStateeven whenprofileKeyStateis set — intentional, nothing is actively verifying the keys